user story #2456007: [Jenkins plugin] unit to runner keep backward compatibility #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itayka
reviewed
Apr 10, 2024
...tions-sdk/src/main/java/com/hp/octane/integrations/uft/MbtDiscoveryResultDispatcherImpl.java
Outdated
Show resolved
Hide resolved
itayka
reviewed
Apr 10, 2024
...rations-sdk/src/main/java/com/hp/octane/integrations/uft/MbtDiscoveryResultPreparerImpl.java
Outdated
Show resolved
Hide resolved
itayka
reviewed
Apr 11, 2024
| @@ -32,4 +32,18 @@ public static boolean isUnitToRunnerRelationDefined(EntitiesService entitiesServ | |||
| List<Entity> entities = entitiesService.getEntities(workspaceId, "metadata/fields", Arrays.asList(condition1, condition2), Collections.emptyList()); | |||
| return !entities.isEmpty(); | |||
| } | |||
|
|
|||
| public static boolean isNewRunner(EntitiesService entitiesService, Long workspaceId, String runnerId) { | |||
There was a problem hiding this comment.
As far as I see, these new 2 methods are used only to check the unit to runner experiment status. So, you can combine them to a single method since it is used in multiple locations.
There was a problem hiding this comment.
No, one is experiment and the second should identify if it is an old runner or newly created
itayka
reviewed
Apr 11, 2024
| List<String> fields = new ArrayList<>(Arrays.asList(EntityConstants.MbtUnit.ID_FIELD, EntityConstants.MbtUnit.NAME_FIELD, | ||
| EntityConstants.MbtUnit.DESCRIPTION_FIELD, EntityConstants.MbtUnit.REPOSITORY_PATH_FIELD)); | ||
| if (bUnitToRunner) { | ||
| if (unitToRunnerEnabled) { |
There was a problem hiding this comment.
This a general question and sorry for its length.
What will happen in the following scenario? It is relevant to both plugin and FTE:
- A user creates a new MBT test runner (Jenkins or FTE).
- Discovery creates all the units in Octane. The units are connected to both the test runner and the scm repository
- The user deletes the test runner. As a result, the link to the test runner will be deleted but the units will still be connected to the scm repository
- Now the user creates a new test runner with the same repository as before. Will the units be linked to the ew test runner before running the discovery? If not, this flow will not update the test runner link on the old units
There was a problem hiding this comment.
Yes, units will connect to the new runner, as in FTE
itayka
approved these changes
Apr 11, 2024
andreibangau99
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.