Skip to content

fix rows_per_page error #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cssailing
Copy link

fix the error of rows_per_page select all option value -1
option === -1

fix the error of rows_per_page select all option value -1 
option === -1
@MicroDroid
Copy link
Owner

I haven't tested the fork yet but what does this exactly fix? I suppose this merely breaks the component instead of fixing anything. 🤔

@cssailing
Copy link
Author

when you have select the option all, the option value will be -1, fixed the value option as
:value="option === -1 ? rows.length : option"
make the all select work

@cssailing
Copy link
Author

you can view the demo-Custom pagination table, select show all, report errors

@MicroDroid
Copy link
Owner

Alright I'll check this out in a moment.

@MicroDroid
Copy link
Owner

Thanks for your effort in making this PR, however, I opted into a slightly different solution to cover some other edge cases that can occur in the 5e2d1ae

🎉

@MicroDroid MicroDroid closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants