-
Notifications
You must be signed in to change notification settings - Fork 65
Added default column sort prop #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great, I'll take a look very soon.
…On Mon, Jul 15, 2019 at 2:53 PM justice47 ***@***.***> wrote:
Based on #26
<#26> issue
------------------------------
You can view, comment on, or merge this pull request online at:
#42
Commit Summary
- changes to README, added demo button
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- few markdown tests
- switch double quotes to single quotes
- added docs dist and docs src
- merged with actual original
- sync with dev changes - initial sort by second column + new table
body slot
- added default sorting option
- made some changes for pr
- some changes for pr
- some changes for pr
File Changes
- *M* README.md
<https://github.com/MicroDroid/vue-materialize-datatable/pull/42/files#diff-0>
(2)
- *M* src/DataTable.vue
<https://github.com/MicroDroid/vue-materialize-datatable/pull/42/files#diff-1>
(6)
Patch Links:
- https://github.com/MicroDroid/vue-materialize-datatable/pull/42.patch
- https://github.com/MicroDroid/vue-materialize-datatable/pull/42.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=ACBA274R474H3OD2CZS4UKTP7RQKBA5CNFSM4IDV7DZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7GM7VQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACBA275XZJJXSC4MXQJTCHDP7RQKBANCNFSM4IDV7DZQ>
.
|
Alright I haven't tested this cause webpack went jank and I'm too tired for this 🙄 I'll rely on your testing, the changes seem fine to me, but please add detailed documentation for this in README, and I'll merge this. |
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26 issue