Skip to content

README.md - Link to demo page and changes to table #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 17, 2019

Conversation

justice47
Copy link
Contributor

  • Added link to demo page
  • Changed formatting in table with props

@MicroDroid
Copy link
Owner

You must merge the GitHub pages demo branch to here, aside from this.

@justice47
Copy link
Contributor Author

You must merge the GitHub pages demo branch to here, aside from this.

Hi! How can I make this? I can only make a PR, demo page made as a standalone vue app, so should I make PR to some branch inside main project (vue-materialize-datatable)?

@MicroDroid
Copy link
Owner

@justice47 Hi, sorry for the delayed response, I read the email and forgot to reply.

Yes, you make a branch called gh-pages, push stuff there and make a PR for it. Make sure to include source and not just compiled files, as well.

@justice47 justice47 changed the title Demo page and change to table README.md - Link to demo page and changes to table Jun 11, 2019
@justice47
Copy link
Contributor Author

@MicroDroid no problem!
I've created new branch in my fork of vue-materialize-datatable, but then I'm trying to make a PR to your master branch, github shows message:
"There isn’t anything to compare.
MicroDroid:master and justice47:gh-pages are entirely different commit histories."
I think you should create empty branch, and then I can push gh-pages branch to it.

@MicroDroid
Copy link
Owner

Alright created the branch, try now see if it works.

@MicroDroid
Copy link
Owner

Wait this wouldn't work, uhh, will have a further look in a little while

@MicroDroid
Copy link
Owner

@justice47 Hey there, you can put everything in docs/ folder with the master branch be done with it, no need for extra branches. Just push changes to this PR maybe.

Now for the source, maybe put it in a directory outside docs/, no idea where just find something appropriate, and put compiled stuff in docs/ so I configure GitHub to serve from it.

Thanks for everything and sorry for BIG delays.

@justice47
Copy link
Contributor Author

@MicroDroid hi!
I've added docs dist and docs src in new commit.

@MicroDroid
Copy link
Owner

heh I'm too lazy to review this PR.

I'll blindly merge it; I hope it works well enough 👀

@MicroDroid MicroDroid merged commit 0d178d7 into MicroDroid:master Jun 17, 2019
@MicroDroid
Copy link
Owner

Alright there were a few issues, got rid of them and fixed them up. It's up now on https://microdroid.github.io/vue-materialize-datatable/

Thanks a lot @justice47!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants