Skip to content

Material icons from npm #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Material icons from npm #18

wants to merge 4 commits into from

Conversation

danilopolani
Copy link
Contributor

@danilopolani danilopolani commented Jun 27, 2017

Using npm module of material icons there is no longer a need to include the icons with an import/link, so you can use the datatable also in offline projects.

PS: I used @import('~material..') but I don't know if it's compatible for plain CSS/Webpack and other

@thepill
Copy link
Collaborator

thepill commented Jun 27, 2017

@MicroDroid I´m not sure about that - this will increase the size and it could be possible that the users already fetching the font from google, so they will download unnecessary data. Also i'm not sure about the @import statement.

@danilopolani For upcoming ideas it could be great if you first could create a issue to tell your idea. We could argue about that and It prevents you from implementing something wich would not necessarily be merged into it. Thanks :)

@MicroDroid
Copy link
Owner

I'm just thinking, given that the user is already loading Material Icons from some other source, wouldn't this forcefully load it again since it's seemingly coming from a new source? and possibly end up with the font being loaded more than once in the final bundle?

Me thinks it's better to keep the font external so we're sure its loaded once plus loading it from a CDN makes the browser benefit from caching, as it's very likely for the browser to already have a cached copy of such resource. Not entirely sure though myself about it.

@danilopolani
Copy link
Contributor Author

Okay, then I think you can just add the npm module to the Readme as alternative to google web fonts, can I create a PR with the suggestion on Readme?

@MicroDroid
Copy link
Owner

I think yes, as an alternative to Google Web Fonts.

@MicroDroid MicroDroid closed this Jun 28, 2017
@MicroDroid
Copy link
Owner

Wait we can keep this open 🤔

@MicroDroid MicroDroid reopened this Jun 28, 2017
@danilopolani danilopolani deleted the npm-icons branch June 28, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants