perPage & defaultPerPage #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroDroid
reviewed
Jun 26, 2017
There was a problem hiding this comment.
I think this is clean implementation and should be bug-free. If @thepill can test this out for us on his environment to make sure, as I am unable to right now.
README.md
Outdated
| printable => Add printing functionality => true (default) // Whether printable | ||
| customButtons => Custom buttons thingy => [ // Array of objects | ||
| perPage => Numbers of rows per page => [10, 20, 30, 40, 50] (default) // Results per page | ||
| defaultperPage => Default rows per page => 10 (default) // Default results per page, otherwise it will be the first value of perPage |
There was a problem hiding this comment.
defaultperPage should become defaultPerPage
| @@ -255,6 +253,36 @@ | |||
| }, | |||
|
|
|||
| computed: { | |||
| perPageOptions: function() { | |||
There was a problem hiding this comment.
This can be very significantly shortened with arrow-functions, and the first few lines can just be
var options = (Array.isArray(this.perPage) && this.perPage) || [10, 20, 30, 40, 50];There was a problem hiding this comment.
Thank you, I edited the readme for the "typo" and used the shorter way for options
There was a problem hiding this comment.
I replaced the longer functions with arrow functions. The rest looks good to me and works in my demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16
perPagewill accept an array of values: the one will be the default and then the values are sorted.Otherwise, you can use
defaultPerPageto set the default value. (Example in the README)