Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previewmodal & main branch code comparison #24

Merged
merged 21 commits into from
Dec 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4e6609b
Added New features such as Preview and Details in a BookList Modal
Michle99 Dec 5, 2023
98597e7
Cleanup...
Michle99 Dec 5, 2023
ff10b30
Added testing libraries, testing setups, & Navbar.test.tsx to check i…
Michle99 Dec 7, 2023
bb91fa9
Added tests for BookCard, BookDetails, BookListPreview and updated ty…
Michle99 Dec 8, 2023
50587d7
Test for `handleBack` function failed. Make an issue to fix.
Michle99 Dec 8, 2023
8ac54b3
Update browser tab icon.
Michle99 Dec 8, 2023
6a877ba
updated BookDetail.test.tsx
Michle99 Dec 8, 2023
83d8f51
Update README.md
Michle99 Dec 8, 2023
635a1f9
Update README.md
Michle99 Dec 8, 2023
1daa849
Updated workflow yml
Michle99 Dec 8, 2023
2e0ee77
Merge branch 'previewmodal' of https://github.com/Michle99/sba_320h_p…
Michle99 Dec 8, 2023
aec7d53
Updated BookDetails test
Michle99 Dec 8, 2023
f2370dd
`BookDetails.test.tsx` test cases passes.
Michle99 Dec 8, 2023
2ad4a32
PreviewModal test to check if it returns `null` on `isOpen=false` pas…
Michle99 Dec 8, 2023
7e8ff6f
Book details is rendered correctly in `PreviewModal.test.tsx`
Michle99 Dec 8, 2023
2a6151b
`PreviewModal` comp tests passes as expected.
Michle99 Dec 8, 2023
975b873
`Footer.test.tsx` test completed and passed.
Michle99 Dec 8, 2023
0c418e8
`SearchBar` Comp 1st 3 tests passes, test search function behavior next.
Michle99 Dec 8, 2023
7e912f7
Updated `SearchBar.test.tsx` & `package.json`
Michle99 Dec 8, 2023
7dc1f66
Updated `SearchBar.test.tsx`
Michle99 Dec 8, 2023
e98811e
`SearchBar.test.tsx` search navigation without `URL space character e…
Michle99 Dec 9, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,25 @@ jobs:

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- name: Cache node modules
uses: actions/cache@v3
env:
cache-name: cache-node-modules
with:
# npm cache files are stored in `~/.npm` on Linux/macOS
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2

- name: setup node
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm ci
- run: npm test --if-present
env:
CI: true
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
<h1>SBA 320: Google Books Search React Application</h1>
</div>

<div align="center">

[![Google_Books_Search_CI](https://github.com/Michle99/sba_320h_project/actions/workflows/main.yml/badge.svg)](https://github.com/Michle99/sba_320h_project/actions/workflows/main.yml)

</div>

## Overview
A React application that allows users to search for books using the Google Books API. Users can view a list of search results and click on a book to see more details.

Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/geekworm.svg" />
<link rel="icon" type="image/jpg" href="/geekworm-logos.jpg" sizes="48x48"/>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>GeekWorm</title>
</head>
Expand Down
11 changes: 11 additions & 0 deletions jest.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
export default {
preset: 'ts-jest',
testEnvironment: 'jest-environment-jsdom',
transform: {
"^.+\\.tsx?$": "ts-jest"
// process `*.tsx` files with `ts-jest`
},
setupFilesAfterEnv: [
"<rootDir>/jest.setup.ts"
],
}
2 changes: 2 additions & 0 deletions jest.setup.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
import '@testing-library/jest-dom/jest-globals';
import '@testing-library/jest-dom';
Loading
Loading