Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Go 1.15: Drop tests cases depending on changing URL behavior
Go 1.15's net/url package changes the handling of escaped URL fragments to preserve the original escaping when possible. For example, fmt.Println(url.Parse("https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz")) // Go 1.14: https://example.com/amp.html#htmlURL=http://bar.com/baz <nil> // Go 1.15: https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz <nil> Upstream change: https://go.googlesource.com/go/+/8c00e07# Drop two test cases that depend on the exact behavior of Go 1.14, which will break when run with Go 1.15. These tests have comments indicating that the preferred result would be that of Go 1.15. Since these tests appear to exist specifically to exercise the undesired path (there are other test cases exercising escaping URL fragments), dropping the tests seems simplest. PiperOrigin-RevId: 312422252
- Loading branch information