Handles the START response #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #8 Replaces the previous started boolean with an enum of possible states. Only set the status to started after receiving the START response. Previously we assumed we were started after we sent the initial START message. This makes room for a stream so apps can listen to the status changes, but this does not include the stream. Add unit tests for verifying status set correctly.
Pull Request Test Coverage Report for Build 56
💛 - Coveralls |
zbarbuto
approved these changes
Jan 2, 2019
MichaelMarner
force-pushed
the
feature/8-start-action
branch
from
912de77 to
437deba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Replaces the previous started boolean with an enum of possible states.
Only set the status to started after receiving the START response.
Previously we assumed we were started after we sent the initial START
message.
This makes room for a stream so apps can listen to the status changes,
but this does not include the stream.
Add unit tests for verifying status set correctly.
cc @zbarbuto