Skip to content

DietPi-Software | Split youtube-dl into own software title#4553

Merged
MichaIng merged 7 commits into
devfrom
youtube-dl
Jul 11, 2021
Merged

DietPi-Software | Split youtube-dl into own software title#4553
MichaIng merged 7 commits into
devfrom
youtube-dl

Conversation

@nonnorm
Copy link
Copy Markdown
Collaborator

@nonnorm nonnorm commented Jul 10, 2021

Status: Ready

Commit list/description:

  • DietPi-Software | Split youtube-dl into own software title

+ DietPi-Software | Split youtube-dl into own software title
@nonnorm nonnorm added this to the v7.4 milestone Jul 10, 2021
@nonnorm nonnorm requested review from Joulinar and MichaIng July 10, 2021 17:23
@nonnorm nonnorm self-assigned this Jul 10, 2021
MichaIng added 2 commits July 11, 2021 14:24
+ DietPi-Software | youtube-dl: It requires Python, supports Python 2 and Python 3, but its shebang calls Python 2, else fails. We hence install the binary with Python 2 suffix and create a shell wrapper to call it with Python 3. Related issue(s): ytdl-org/youtube-dl#27649
+ DietPi-Software | O!MPD: Remove obsolete Python 2 requests module dependency. youtube-dl is setup to use Python 3 and O!MPD accesses Tidal via PHP API now: ArturSierzant/OMPD@3346ee1
+ DietPi-Software | Remove trailing space
@MichaIng
Copy link
Copy Markdown
Owner

Not to forget that youtube-dl is a Python script/binary (not sure, the content is no plain text but it still must be called with Python and has a shebang accordingly, how does one call such? 😄). Strangely it still has a Python 2 shebang, so to allow calling it directly, I added a wrapper script to call it with Python 3. I verified that its internal update -U option works fine, updating the actual executable and not the wrapper script. As more and more distros remove Python 2 and hence more and more users report issues with this shebang, I hope the developer will adjust the shebang soon to explicitly call for Python 3. Then we can remove this ugly wrapper workaround.

I explicitly did not use the dependency system to pull Python 3, as this pull the whole development stack and pip, which is all not required here. Somehow we might want to make clear that For running Python scripts, apt install python3 is totally fine, while our install option is only required for using pip and/or compiling Python modules (the first usually implies the second).

MichaIng added 4 commits July 11, 2021 14:39
+ META | Update youtube-dl branch
+ README | Add youtube-dl sources to 3rd party list
+ DietPi-Survey_report | youtube-dl has been added
+ CHANGELOG | youtube-dl: The famous command-line program to download videos from YouTube and other video platforms has been added to DietPi-Software with ID 195.
@MichaIng MichaIng mentioned this pull request Jul 11, 2021
5 tasks
@MichaIng MichaIng merged commit 2a11e18 into dev Jul 11, 2021
@MichaIng MichaIng deleted the youtube-dl branch July 11, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants