dietpi-drive_manager gives errors for mounted network drives

[maartenlangeveld]

 ─────────────────────────────────────────────────────
 DietPi v7.2.3 : 10:32 - Thu 06/10/21
 ─────────────────────────────────────────────────────
 - Device model : NanoPi NEO2 (aarch64)
 - Uptime : up 25 minutes
 - CPU temp : 40'C : 104'F (Optimal temperature)
 - FQDN/hostname : M-DNS
 - LAN IP : 192.x.x.x (eth0)
 - WAN IP : x.x.x.x South Holland Netherlands
 - Freespace (RootFS) : 23G
 - MOTD : DietPi v7.2 has been released, please update now.
 ─────────────────────────────────────────────────────

root@M-DNS:/mnt# dietpi-drive_manager
[ INFO ] DietPi-Drive_Manager | Detecting drives, please wait...
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: /dev/mmcblk0p1 > /
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: 192.x.x.x:/ > /mnt/nanopi-backup-rpi-zero-w
[FAILED] DietPi-Drive_Manager | The following drive seems to not have a UUID, skipping fstab entry:
SOURCE           TARGET                        FSTYPE UUID
192.x.x.x:/ /mnt/nanopi-backup-rpi-zero-w nfs4
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: 192.x.x.x:/mnt/main/backup/nanopi-backup/dietpi-backup > /mnt/nanopi-backup-m-server
[FAILED] DietPi-Drive_Manager | The following drive seems to not have a UUID, skipping fstab entry:
SOURCE                                                     TARGET                      FSTYPE UUID
192.x.x.x:/mnt/main/backup/nanopi-backup/dietpi-backup /mnt/nanopi-backup-m-server nfs4
[ INFO ] DietPi-Drive_Manager |  - Detected unmounted drive: /dev/sda1

[Joulinar]

Hi,

what typ of network drive is this? NFS?

---

@MichaIng
same behaviour on NFS as well as on SMB

[ INFO ] DietPi-Drive_Manager | Detecting drives, please wait...
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: /dev/sda2 > /
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: /dev/sda1 > /boot
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: 192.168.0.10:/volume1/NFS > /mnt/nfs_client
[FAILED] DietPi-Drive_Manager | The following drive seems to not have a UUID, skipping fstab entry:
SOURCE                    TARGET          FSTYPE UUID
192.168.0.10:/volume1/NFS /mnt/nfs_client nfs4
[ INFO ] DietPi-Drive_Manager |  - Detected mounted physical drive: //192.168.0.10/Share > /mnt/samba
[FAILED] DietPi-Drive_Manager | The following drive seems to not have a UUID, skipping fstab entry:
SOURCE               TARGET     FSTYPE UUID
//192.168.0.10/Share /mnt/samba cifs
[  OK  ] DietPi-Drive_Manager | mv .fstab /etc/fstab
[  OK  ] DietPi-Drive_Manager | systemctl daemon-reload

EDIT
looks like variable aDRIVE_SOURCE_DEVICE is not utilized correctly. On my test it was always empty. Therefore the check for physical drive succeed all the time. Even on network drives

DietPi/dietpi/dietpi-drive_manager

Line 177 in 4ffa0e5

if [[ -d '/sys/block/'${aDRIVE_SOURCE_DEVICE[$index]} ]]; then

[MichaIng]

Many thanks for reporting.

A tricky thing. The physical drive detection was not optimal anyway, as it theoretically allowed to have drives detected as physical ones, even when they had no /dev/ entry, respectively their mount source did not start with /dev/, which is expected in many other places. With this change we use this prefix now to device whether it's physical or not: cb95aa5
Changelog: 94adad0

But the other way round, there are potentially mount types (encrypted filesystems, LVM drives) now detected as physical ones, which were detected as network drives before. The script will hence now add fstab entries for those, at least if it has a UUID as well, while before, any existing fstab entry for it would have been lost. Not sure whether it's better or not (if the fstab entry is correct in these cases), but it needs to be kept an eye one.

[MichaIng]

It did affect all network drives. At least the result is exactly the same as if it was detected correctly. Only you'll see some unintended options, like the ability to format it or create a swap file, which both does not make sense for a network drive 😄.