Fix the heap and use of IPI

kernel/handle.c

@@ -21,6 +21,7 @@
  * - Implementation of the resource handle interface. This provides system-wide
  *   resource handles and maintience of resources. 
  */
+
 #define __MODULE "HNDL"
 //#define __TRACE
 

kernel/heap.c

@@ -676,6 +676,7 @@ MemoryCacheAllocate(
 
         Index = slab_allocate_index(Cache, Slab);
         assert(Index != -1);
+
         if (!Slab->NumberOfFreeObjects) {
             list_remove(&Cache->PartialSlabs, &Slab->Header);
             list_append(&Cache->FullSlabs, &Slab->Header);
@@ -702,10 +703,10 @@ MemoryCacheAllocate(
             list_append(&Cache->FullSlabs, &Slab->Header);
         }
         else {
-            Cache->NumberOfFreeObjects += (Cache->ObjectCount - 1);
             list_append(&Cache->PartialSlabs, &Slab->Header);
+            smp_wmb();
+            Cache->NumberOfFreeObjects += (Cache->ObjectCount - 1);
         }
-        smp_wmb();
     }
 
     Allocated = MEMORY_SLAB_ELEMENT(Cache, Slab, Index);
@@ -766,6 +767,7 @@ MemoryCacheFree(
     // Handle debug flags
     if (Cache->Flags & HEAP_DEBUG_USE_AFTER_FREE) {
         memset(Object, MEMORY_OVERRUN_PATTERN, Cache->ObjectSize);
+        smp_wmb();
     }
 
     // Can we push to cpu cache?

kernel/include/component/cpu.h

@@ -62,7 +62,7 @@ typedef struct TxuMessage {
     void*         Argument;
 } TxuMessage_t;
 
-#define TXU_MESSAGE_INIT(Msg, Fn, Arg)  ELEMENT_INIT(&(Msg)->Header, 0, Msg); (Msg)->Handler = Fn; (Msg)->Argument = Arg
+#define TXU_MESSAGE_INIT(Msg, Fn, Arg)  ELEMENT_INIT(&Msg->Header, 0, Msg); Msg->Handler = Fn; Msg->Argument = Arg
 
 typedef struct SystemCpuCore {
     UUId_t            Id;

kernel/machine.c

@@ -130,6 +130,9 @@ InitializeMachine(
         ERROR("Failed to initialize output for system.");
         ArchProcessorHalt();
     }
+
+    // Initialize all those who need the heap system in place
+    TxuMessageCacheInitialize();
 
     // Build system topology by enumerating the SRAT table if present.
     // If ACPI is not present or the SRAT is missing the system is running in UMA

kernel/memoryspace.c

@@ -76,6 +76,7 @@ SynchronizeMemoryRegion(
     // We can easily allocate this object on the stack as the stack is globally
     // visible to all kernel code. This spares us allocation on heap
     MemorySynchronizationObject_t Object = { { { 0 } } };
+    TxuMessage_t*                 Message = &Object.Header;
     int                           NumberOfCores;
 
     // Skip this entire step if there is no multiple cores active
@@ -96,7 +97,7 @@ SynchronizeMemoryRegion(
         }
     }
 
-    TXU_MESSAGE_INIT(&Object.Header, MemorySynchronizationHandler, &Object);
+    TXU_MESSAGE_INIT(Message, MemorySynchronizationHandler, &Object);
     Object.Address        = Address;
     Object.Length         = Length;
     Object.CallsCompleted = 0;

modules/storage/msd/msd.c

@@ -136,27 +136,27 @@ MsdDeviceCreate(
         goto Error;
     }
 
-    // Perform setup
     if (MsdDeviceStart(Device) != OsSuccess) {
         ERROR("Failed to initialize the device");
         goto Error;
     }
 
-    // Start out by initializing the contract
     InitializeContract(&Device->Contract, Device->Base.Base.Id, 1,
         ContractStorage, "MSD Storage Interface");
-
-    // Register contract before interrupt
     if (RegisterContract(&Device->Contract) != OsSuccess) {
         ERROR("Failed to register storage contract for device");
     }
 
-    // Notify diskmanager
+    // Wait for the disk service to finish loading
+    if (WaitForFileService(1000) != OsSuccess) {
+        ERROR("[msd] disk ready but storage service did not start");
+        // TODO: what do
+        return Device;
+    }
+
     if (RegisterStorage(Device->Base.Base.Id, __STORAGE_REMOVABLE) != OsSuccess) {
         ERROR("Failed to register storage with storagemanager");
     }
-
-    // Done
     return Device;
 
 Error:

revision.h

@@ -3,12 +3,12 @@
 #ifndef _REVISION_H_
 #define _REVISION_H_
 
-#define BUILD_DATE "18 November 2019"
-#define BUILD_TIME "14:04:42"
+#define BUILD_DATE "19 November 2019"
+#define BUILD_TIME "12:13:50"
 #define BUILD_SYSTEM "clang"
 
 #define REVISION_MAJOR 0
 #define REVISION_MINOR 6
-#define REVISION_BUILD 12887
+#define REVISION_BUILD 12895
 
 #endif //!_REVISION_H_

services/filemanager/main.c

@@ -169,9 +169,6 @@ VfsIdentifierFree(
     }
 }
 
-/* OnLoad
- * The entry-point of a server, this is called
- * as soon as the server is loaded in the system */
 OsStatus_t
 OnLoad(
     _In_ char** ServicePathOut)
@@ -180,9 +177,6 @@ OnLoad(
     return OsSuccess;
 }
 
-/* OnUnload
- * This is called when the server is being unloaded
- * and should free all resources allocated by the system */
 OsStatus_t
 OnUnload(void)
 {