Skip to content

Conversation

pedroc-met
Copy link
Contributor

@pedroc-met pedroc-met commented Mar 19, 2025

Goal

Added fixed speed pump component and tests; modified variable speed pump icon.

Resolves #521

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass
  • I have checked that my work is compatible with OpenModelica
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@pedroc-met pedroc-met added the ✨enhancement New feature or request label Mar 19, 2025
@pedroc-met pedroc-met requested a review from nabily-met March 19, 2025 15:54
@pedroc-met pedroc-met self-assigned this Mar 19, 2025
@pedroc-met pedroc-met linked an issue Mar 19, 2025 that may be closed by this pull request
@pedroc-met pedroc-met marked this pull request as ready for review March 19, 2025 16:05
Copy link
Contributor

@nabily-met nabily-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the pumps in the metroscopia models. Make sure that the new pump is giving the same outputs.

pedroc-met and others added 5 commits March 19, 2025 18:09
Co-authored-by: nyoussef <99659896+nabily-met@users.noreply.github.com>
…g a superheater fouling that no longer exists)
…h fixed speed pumps and tested comparing to previous versions
…th fixed speed pumps and tested comparing to previous versions
@pedroc-met
Copy link
Contributor Author

Change the pumps in the metroscopia models. Make sure that the new pump is giving the same outputs.

Done in MetroscopiaNPP and MetroscopiaCCGT :)

@pedroc-met pedroc-met requested a review from nabily-met March 21, 2025 16:08
@pedroc-met pedroc-met merged commit 325fb11 into main Mar 21, 2025
@pedroc-met pedroc-met deleted the 521-feature-add-fixed-speed-pump branch March 21, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Remove rh_min from pump model

2 participants