-
Notifications
You must be signed in to change notification settings - Fork 2
Add reactor #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reactor #481
Conversation
I think you forgot to add the test models to your commit, the "Add tests" has no changes to show |
Ups yeah something went wrong. I added the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but it looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the changelog and add the component to the documentation
Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>
Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>
Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the changelog
Goal
Add reactor component. (Fix #476) Its an additional component, I didnt manage to extend this to use for Steam Generator. (BC of different design, and purge)
Type of change
package.mo
)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.