Skip to content

Conversation

moritzn-met
Copy link
Contributor

@moritzn-met moritzn-met commented Apr 9, 2024

Goal

Add reactor component. (Fix #476) Its an additional component, I didnt manage to extend this to use for Steam Generator. (BC of different design, and purge)

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass.
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@hadrienp-met
Copy link
Contributor

I think you forgot to add the test models to your commit, the "Add tests" has no changes to show

@moritzn-met
Copy link
Contributor Author

I think you forgot to add the test models to your commit, the "Add tests" has no changes to show

Ups yeah something went wrong. I added the tests!

@moritzn-met moritzn-met requested a review from hadrienp-met April 9, 2024 14:14
Copy link
Contributor

@hadrienp-met hadrienp-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but it looks good to me

@hadrienp-met hadrienp-met self-requested a review April 11, 2024 11:51
Copy link
Contributor

@hadrienp-met hadrienp-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the changelog and add the component to the documentation

moritzn-met and others added 3 commits April 11, 2024 15:18
Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>
Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>
Co-authored-by: Hadrien <113358529+hadrienp-met@users.noreply.github.com>
Copy link
Contributor

@hadrienp-met hadrienp-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the changelog

@hadrienp-met hadrienp-met merged commit 8f74cf8 into main Apr 15, 2024
@hadrienp-met hadrienp-met deleted the add-reactor branch April 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Create a PrimaryHX

2 participants