Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclasses #99

Merged
merged 12 commits into from
May 24, 2022
Merged

Use dataclasses #99

merged 12 commits into from
May 24, 2022

Conversation

Buried-In-Code
Copy link
Member

@Buried-In-Code Buried-In-Code commented May 6, 2022

  • Rewrite Simyan to use dataclasses-json instead of Marshmallow
    • All data objects are now located in simyan.schemas.* instead of simyan.*
  • All id references have been renamed to id_
  • simyan.session.Session has been renamed simyan.comicvine.Comicvine
  • The following functions have had their params renamed:
    • Comicvine.publisher(self, _id) => Comicvine.publisher(self, publisher_id)
    • Comicvine.volume(self, _id) => Comicvine.volume(self, volume_id)
    • Comicvine.issue(self, _id) => Comicvine.issue(self, issue_id)
    • Comicvine.story_arc(self, _id) => Comicvine.story_arc(self, story_arc_id)
    • Comicvine.creator(self, _id) => Comicvine.creator(self, creator_id)
    • Comicvine.character(self, _id) => Comicvine.character(self, character_id)
  • The following functions have had their return types updated:
    • publisher_list.PublisherList => List[PublisherResult]
    • volume_list.VolumeList => List[VolumeResult]
    • issue_list.IssueList => List[IssueResult]
    • story_arc_list.StoryArcList => List[StoryArcList]
    • creator_list.CreatorList => List[CreatorList]
    • character_list.CharacterList => List[CharacterList]
  • Included fix from Fix Issue Schema for missing description field #90
  • Removed deprecated functions
    • create_session()
    • api()
  • Updated dependencies

@Buried-In-Code
Copy link
Member Author

Happy to hear suggestions, before this is merged in

@Buried-In-Code
Copy link
Member Author

Includes fix for #100

@Buried-In-Code Buried-In-Code linked an issue May 24, 2022 that may be closed by this pull request
@Buried-In-Code Buried-In-Code merged commit a9485c6 into main May 24, 2022
@Buried-In-Code Buried-In-Code deleted the use-dataclasses branch May 24, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IssueList APIError: 'cover_date' field may not be null.
1 participant