-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #42
Merged
Merged
Documentation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Not quite sure why this wasn't there to begin with.
Apparently my pre-commit wasn't installed correcly.
- This is need for readthedocs support
- Add check so new code adds/formats docstrings
Oh, one thing I forgot. The project didn't seem to be using the standard |
Yup, tho the function name should probably be change to `test_issue_list_has_staff_review` Co-authored-by: Buried-In-Code <6057651+Buried-In-Code@users.noreply.github.com>
@bpepple are you ok with fixing these conflicts? |
I can give them a look later tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add some documentation to the project.
First thing you'll want to do is install the optional doc dependencies. These are needed since poetry is a realitively new project and doesn't have proper support with ReadTheDocs. To add them you need to run
poetry install -E docs
.To create the documentation locally, you would change to the docs directory and run
make html
. The results can be then found in docs/build/html directory.If a new module is added to the project, you will need to go to the docs directory and run
sphinx-apidoc -o source ../Simyan
to have that module's documentation added.To host the documentation at ReadTheDocs, the first thing you need to do is create an account there. Once there you should be able to import the repo. I've already added a readthedoc.yml to the project so there should not be much configuration needed, but if you into any problems just holler.