Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #42

Merged
merged 33 commits into from
Sep 22, 2021
Merged

Documentation #42

merged 33 commits into from
Sep 22, 2021

Conversation

bpepple
Copy link
Member

@bpepple bpepple commented Sep 14, 2021

This pull request will add some documentation to the project.

First thing you'll want to do is install the optional doc dependencies. These are needed since poetry is a realitively new project and doesn't have proper support with ReadTheDocs. To add them you need to run poetry install -E docs.

To create the documentation locally, you would change to the docs directory and run make html. The results can be then found in docs/build/html directory.

If a new module is added to the project, you will need to go to the docs directory and run sphinx-apidoc -o source ../Simyan to have that module's documentation added.

To host the documentation at ReadTheDocs, the first thing you need to do is create an account there. Once there you should be able to import the repo. I've already added a readthedoc.yml to the project so there should not be much configuration needed, but if you into any problems just holler.

- Not quite sure why this wasn't there to begin with.
Apparently my pre-commit wasn't installed correcly.
- This is need for readthedocs support
- Add check so new code adds/formats docstrings
@bpepple
Copy link
Member Author

bpepple commented Sep 14, 2021

Oh, one thing I forgot. The project didn't seem to be using the standard __version__ when the it's being initialized, and for the documentation it's useful to have. So, when you publish new releases you need to make sure to update the values in the project.toml & the project __init__.py.

Yup, tho the function name should probably be change to `test_issue_list_has_staff_review`

Co-authored-by: Buried-In-Code <6057651+Buried-In-Code@users.noreply.github.com>
@bpepple bpepple closed this Sep 14, 2021
@bpepple bpepple reopened this Sep 14, 2021
@Buried-In-Code
Copy link
Member

@bpepple are you ok with fixing these conflicts?

@bpepple
Copy link
Member Author

bpepple commented Sep 22, 2021

I can give them a look later tonight

@Buried-In-Code Buried-In-Code merged commit 5e1a0d2 into Metron-Project:main Sep 22, 2021
@bpepple bpepple deleted the documentation branch September 22, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants