Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove staff review #28

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Remove staff review #28

merged 5 commits into from
Sep 8, 2021

Conversation

Buried-In-Code
Copy link
Member

@Buried-In-Code Buried-In-Code commented Sep 8, 2021 •
edited
Loading

  • Removes has_staff_review from both IssueSchema and IssueResultSchema
  • Changes COMICVINE_KEY environment variable to COMICVINE_API_KEY

Closes #27

@bpepple
Copy link
Member

bpepple commented Sep 8, 2021

It's probably worth adding a test with a known has_staff_review value to the test cache to verify that the schema doesn't fail validation.

@Buried-In-Code Buried-In-Code merged commit c6e7b36 into main Sep 8, 2021
@Buried-In-Code Buried-In-Code deleted the remove-staff-review branch September 8, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IssueResultSchema Validation Error
2 participants
@Buried-In-Code @bpepple