Skip to content

Add Description for Azure RMService Connection - #516

Merged
SebastianSchuetze merged 16 commits into
MethodsAndPractices:trunkfrom
arturopolanco:patch-for-serviceconnction
Apr 18, 2023
Merged

Add Description for Azure RMService Connection#516
SebastianSchuetze merged 16 commits into
MethodsAndPractices:trunkfrom
arturopolanco:patch-for-serviceconnction

Conversation

@arturopolanco

Copy link
Copy Markdown
Contributor

PR Summary

Description field is added to the "Add-VSTeamAzureRMServiceEndpoint" cmdlet. As it is already part of the AzDo API is enough to add it to the JSON object and parse it to "Add-VSTeamServiceEndpoint"

PR Checklist

@SebastianSchuetze

Copy link
Copy Markdown
Contributor

@arturopolanco somehow the reference is not found when running unit tests on Ubuntu.

@SebastianSchuetze

Copy link
Copy Markdown
Contributor

Also please update the version in the psd1 file.

@arturopolanco
arturopolanco marked this pull request as draft April 18, 2023 08:11
@arturopolanco
arturopolanco marked this pull request as ready for review April 18, 2023 08:17
@arturopolanco

Copy link
Copy Markdown
Contributor Author

@arturopolanco somehow the reference is not found when running unit tests on Ubuntu.

Hey Sebastian, there was a wrong reference, I should work now. let me know how it goes

@SebastianSchuetze
SebastianSchuetze self-requested a review April 18, 2023 13:26

@SebastianSchuetze SebastianSchuetze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fine. I can merge!

@SebastianSchuetze
SebastianSchuetze merged commit e8be72c into MethodsAndPractices:trunk Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants