Skip to content

Fix/dt 483 add previous file - #42

Open
pirmink wants to merge 3 commits into
mainfrom
fix/DT-483-add-previous_file
Open

pirmink wants to merge 3 commits into
mainfrom
fix/DT-483-add-previous_file

Conversation

@pirmink

@pirmink pirmink commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

To de-accumulate precipitation, one needs the precipitation of the step before.

@pirmink

pirmink commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

The file of the step before is stored in the variable previous_file, but was not passed into neither load_grib() nor preprocess(). @ninaburg suspects that the precipitation for step t is de-accumulated with step t = 0 instead of step t - 1 and suggested this change. The simple addition of previous_file however leads to pytest failing. I therefore mark this PR as draft. @victoria-cherkas please check if the change is correct and how the tests need to be adapted to pass pytest.

@victoria-cherkas
victoria-cherkas marked this pull request as ready for review October 6, 2026 13:40

@victoria-cherkas victoria-cherkas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! I had to add one smalll change to fix the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants