Make context macros self-contained #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardwhiuk
approved these changes
Feb 11, 2020
|
bors delegate+ |
|
✌️ bossmc can now approve this pull request. To approve and merge a pull request, simply reply with |
Signed-off-by: Andy Caldwell <andrew.caldwell@metaswitch.com>
bossmc
force-pushed
the
macro-ergonomics
branch
from
4190b55 to
71b99eb
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 11, 2020
97: Make context macros self-contained r=bossmc a=bossmc With this, the various `make_context_X` macros never reference names from the local crate without fully qualifying them. Without this, users of the macros would have to `use` various swagger traits/macros (or `#[macro_use]` the crate). Co-authored-by: Andy Caldwell <andrew.caldwell@metaswitch.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the various
make_context_Xmacros never reference names from the local crate without fully qualifying them. Without this, users of the macros would have tousevarious swagger traits/macros (or#[macro_use]the crate).