This repository was archived by the owner on Feb 27, 2020. It is now read-only.
[Reviewer Andy] Fixes #569 - Add extra context to error logs for HSSConnection #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This inlines the PUT body, where elsewhere you've made a point of putting it on its own line. Worried that large bodies will make this log hard to use.
|
Not much to say, looks pretty good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andy
Can you review my updates to Sprout's HSSConnection class to add context to the error logs. I was finding it was impossible to correlate these errors to SAS output because the logs didn't have any context and I decided it would also make sense to ensure the bodies sent and received were logged as well, which required a bit of restructuring.
Mike