Skip to content

open discrete bounds should show >= next value #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lsabor wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Draft

open discrete bounds should show >= next value #3732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions front_end/src/components/forecast_maker/continuous_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ const ContinuousTable: FC<Props> = ({
<Td></Td>
{question.open_lower_bound && (
<Td className="rounded bg-blue-400/60 p-1 dark:bg-blue-600/20 ">
{getDisplayValue(0)}
{getDisplayValue(-0.1)}
</Td>
)}
<Td className="rounded bg-blue-400/60 p-1 dark:bg-blue-600/20">
Expand All @@ -203,7 +203,7 @@ const ContinuousTable: FC<Props> = ({
</Td>
{question.open_upper_bound && (
<Td className="rounded bg-blue-400/60 p-1 dark:bg-blue-600/20">
{getDisplayValue(1)}
{getDisplayValue(1.1)}
</Td>
)}
</>
Expand Down
4 changes: 2 additions & 2 deletions front_end/src/utils/charts/axis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ export function generateScale({
!isNil(rangeMax)
) {
discreteValueOptions = [];
for (let i = 0; i < inbound_outcome_count; i++) {
for (let i = -1; i < inbound_outcome_count + 1; i++) {
discreteValueOptions.push(
rangeMin + ((rangeMax - rangeMin) * (i + 0.5)) / inbound_outcome_count
);
Expand All @@ -522,7 +522,7 @@ export function generateScale({
) {
// get last label width to determine the number of labels
const lastLabel = getPredictionDisplayValue(
1 - 0.5 / inbound_outcome_count,
1 + 0.5 / inbound_outcome_count,
{
questionType: displayType as QuestionType,
scaling: rangeScaling,
Expand Down
2 changes: 1 addition & 1 deletion front_end/src/utils/formatters/prediction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function getDiscreteValueOptions(
return undefined;
}
const discreteValueOptions: number[] = [];
for (let i = 0; i < question.inbound_outcome_count; i++) {
for (let i = -1; i < question.inbound_outcome_count + 1; i++) {
discreteValueOptions.push(
question.scaling.range_min +
((question.scaling.range_max - question.scaling.range_min) *
Expand Down