Refactor Notification Emails #3586
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace django-mjml wrapper with direct MJML CLI to avoid stderr issues - Add os.path.normpath() to properly resolve relative include paths - Strip temp file path comments from compiled HTML (cleaner git diffs) - Recompile all email templates with improvements Fixes bug where mjml_compose would fail with: RuntimeError: MJML stderr is not empty: DeprecationWarning...
hlbmtc
reviewed
Oct 7, 2025
hlbmtc
reviewed
Oct 7, 2025
hlbmtc
reviewed
Oct 7, 2025
hlbmtc
reviewed
Oct 7, 2025
|
@hlbmtc could you take another quick look, and merge with prod if all looks good? I made some copy / wording changes since your last review, but could still use a second set of eyes before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.