Upgrade TypeScript to 4.7 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump TypeScript and fix compile errors. Specifically, an error that's caught is now typed as `unknown`, so accessing `message` on that error object won't work anymore. This is fixed using a type guard. Also bump `typedoc` to fix peer dependency warnings.
Merged
Mrtenz
previously approved these changes
Aug 18, 2022
Mrtenz
reviewed
Aug 18, 2022
| "typedoc": "^0.22.15", | ||
| "typescript": "^4.2.4" | ||
| "typedoc": "^0.23.10", | ||
| "typescript": "~4.7.4" |
There was a problem hiding this comment.
TypeScript doesn't follow SemVer; minor changes are breaking
Gudahtt
reviewed
Aug 18, 2022
| * @param error - The object to check. | ||
| * @returns True or false, depending on the result. | ||
| */ | ||
| function isErrorWithMessage(error: unknown): error is { message: string } { |
There was a problem hiding this comment.
Oh, I guess it wants a unit test for this
|
Unit tests added ☝🏻 |
Gudahtt
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump TypeScript and fix compile errors. Specifically, an error that's
caught is now typed as
unknown, so accessingmessageon that errorobject won't work anymore. This is fixed using a type guard.
Also bump
typedocto fix peer dependency warnings.