Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Synchronise package with module template to fix ESM build #124

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 24, 2023

This fixes an issue with the ESM build, which makes it not possible to load the package in Node.js when ESM is enabled (MetaMask/metamask-module-template#208).

This was accomplished by running template-sync, and can be validated using npx @metamask/template-sync@latest --check.

Breaking changes

  • This makes it impossible to import from filesystem based paths, such as @metamask/utils/dist/cjs/foo.js.

@Mrtenz Mrtenz requested a review from a team as a code owner July 24, 2023 09:30
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-promise 6.1.1 None +0 67.1 kB eslint-community-bot
eslint-plugin-n 15.7.0 filesystem +4 883 kB weiran.zsd
@metamask/eslint-config-jest 11.1.0...12.1.0 None +2/-1 195 kB metamaskbot
@metamask/eslint-config-typescript 11.1.0...12.1.0 None +2/-1 204 kB metamaskbot
@metamask/eslint-config-nodejs 11.1.0...12.1.0 None +7/-3 1.16 MB metamaskbot
@metamask/eslint-config 11.1.0...12.1.0 None +1/-0 186 kB metamaskbot

🚮 Removed packages: eslint-plugin-node@11.1.0

@socket-security
Copy link

socket-security bot commented Jul 24, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: builtins@5.0.1, eslint-plugin-n@15.7.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Jul 24, 2023

@SocketSecurity ignore-all

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Mrtenz Mrtenz merged commit d94d13c into main Jul 24, 2023
@Mrtenz Mrtenz deleted the mrtenz/fix-esm branch July 24, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants