Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@lavamoat/preinstall-always-fail": "^1.0.0",
"@metamask/auto-changelog": "^3.1.0",
"@metamask/eslint-config": "^11.0.1",
"@metamask/eslint-config-jest": "^11.0.0",
"@metamask/eslint-config-jest": "^14.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency Hell After ESLint Config Upgrade

Upgrading @metamask/eslint-config-jest to ^14.1.0 creates incompatible peer dependency conflicts. The new version requires @metamask/eslint-config@^14.1.0, eslint@^9.11.0, and eslint-plugin-jest@^28.8.3, but the project has @metamask/eslint-config@^11.0.1, eslint@^8.27.0, and eslint-plugin-jest@^27.1.5 installed. Additionally, other eslint config packages (@metamask/eslint-config-nodejs and @metamask/eslint-config-typescript) require the older versions, creating conflicting peer dependencies. ESLint 9 also requires flat configs but the project uses legacy .eslintrc.js format.

Fix in Cursor Fix in Web

"@metamask/eslint-config-nodejs": "^11.0.1",
"@metamask/eslint-config-typescript": "^11.0.0",
"@types/inquirer": "^9.0.3",
Expand Down
33 changes: 25 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,13 @@ __metadata:
languageName: node
linkType: hard

"@eslint/js@npm:^9.11.0":
version: 9.39.1
resolution: "@eslint/js@npm:9.39.1"
checksum: b651930aec03a5aef97bc144627aebb05070afec5364cd3c5fd7c5dbb97f4fd82faf1b200b3be17572d5ebb7f8805211b655f463be96f2b02202ec7250868048
languageName: node
linkType: hard

"@ethereumjs/common@npm:^3.1.2":
version: 3.1.2
resolution: "@ethereumjs/common@npm:3.1.2"
Expand Down Expand Up @@ -992,14 +999,17 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config-jest@npm:^11.0.0":
version: 11.1.0
resolution: "@metamask/eslint-config-jest@npm:11.1.0"
"@metamask/eslint-config-jest@npm:^14.1.0":
version: 14.1.0
resolution: "@metamask/eslint-config-jest@npm:14.1.0"
dependencies:
"@eslint/js": ^9.11.0
globals: ^15.9.0
peerDependencies:
"@metamask/eslint-config": ^11.0.0
eslint: ^8.27.0
eslint-plugin-jest: ^27.1.5
checksum: a649cf317327532d0d18795ac3bc74766e649e821ca3130dac288b16d5243ae72b5bda4eb85c678f1b4f9c073904ac6162b740c237b67921e64ce4f40c6ceb77
"@metamask/eslint-config": ^14.1.0
eslint: ^9.11.0
eslint-plugin-jest: ^28.8.3
checksum: 2c5bd99fb4470206b47360566f1681c93ed2254080297e2fa34392eb5ae64470138e2f67171a09bb6051e6a4a69eaf430f68b82ef8886604b368cc4129c80462
languageName: node
linkType: hard

Expand Down Expand Up @@ -1049,7 +1059,7 @@ __metadata:
"@lavamoat/preinstall-always-fail": ^1.0.0
"@metamask/auto-changelog": ^3.1.0
"@metamask/eslint-config": ^11.0.1
"@metamask/eslint-config-jest": ^11.0.0
"@metamask/eslint-config-jest": ^14.1.0
"@metamask/eslint-config-nodejs": ^11.0.1
"@metamask/eslint-config-typescript": ^11.0.0
"@metamask/utils": ^5.0.1
Expand Down Expand Up @@ -3610,6 +3620,13 @@ __metadata:
languageName: node
linkType: hard

"globals@npm:^15.9.0":
version: 15.15.0
resolution: "globals@npm:15.15.0"
checksum: a2a92199a112db00562a2f85eeef2a7e3943e171f7f7d9b17dfa9231e35fd612588f3c199d1509ab1757273467e413b08c80424cf6e399e96acdaf93deb3ee88
languageName: node
linkType: hard

"globalthis@npm:^1.0.3":
version: 1.0.3
resolution: "globalthis@npm:1.0.3"
Expand Down
Loading