Skip to content

Conversation

@GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Nov 3, 2025

This fixes an old issue where null is not allowed as a valid value in the InputChangeEvent


Note

Allow null for InputChangeEvent.value, add tests, update changelogs, and refresh example snap bundle shasums.

  • SDK / Types:
    • Allow null in InputChangeEvent by making value nullable in InputChangeEventStruct (packages/snaps-sdk/src/types/handlers/user-input.ts).
    • Add unit test to validate null acceptance (packages/snaps-sdk/src/types/handlers/user-input.test.ts).
  • Changelogs:
    • Note fix in packages/snaps-sdk/CHANGELOG.md and packages/snaps-execution-environments/CHANGELOG.md.
  • Examples:
    • Update source.shasum for example snaps (packages/examples/packages/*/snap.manifest.json).

Written by Cursor Bugbot for commit c698209. This will update automatically on new commits. Configure here.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 3, 2025 16:08
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (5a10086) to head (c698209).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3722   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12152    12152           
  Branches     1876     1876           
=======================================
  Hits        11943    11943           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GuillaumeRx GuillaumeRx added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit e5f394c Nov 4, 2025
121 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/allow-null-input-change-event branch November 4, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants