fix(send-flow-snap): add missing displayAvatar props, add tests, update snaps-simulation
#3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
=======================================
Coverage 97.79% 97.80%
=======================================
Files 363 364 +1
Lines 9893 9911 +18
Branches 1613 1616 +3
=======================================
+ Hits 9675 9693 +18
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmalik88
commented
Apr 12, 2025
There was a problem hiding this comment.
Updated the formatting for this SVG (and the ones below) to a consistent flat format since jest flattens it and the SVG transformer picks up the file content with format.
hmalik88
commented
Apr 12, 2025
| // Transform SVG files using our custom transformer | ||
| transform: { | ||
| ...baseConfig.transform, | ||
| '\\.svg$': '<rootDir>/test/transformers/svgTransformer.js', |
There was a problem hiding this comment.
Needed to write a transformer for jest to be able to handle SVGs.
hmalik88
changed the title
displayAvatar props displayAvatar props, add tests, update snaps-simulation
Mrtenz
requested changes
Apr 14, 2025
packages/examples/packages/send-flow/test/transformers/svgTransformer.js
Outdated
Show resolved
Hide resolved
…and tests for printing error messages, add const for tracking typeable inputs
Mrtenz
previously requested changes
Apr 14, 2025
Mrtenz
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The send-flow example snap is only passing the
displayAvatarprop in thetoscenario but not in the others. This can land you in a situation where you paste a valid address in the to field, start to type an amount in the amount field, then the avatar disappears because nodisplayAvatarprop is being passed.Summary of changes
onUserInputcode to properly pass thedisplayAvatarprop in all scenarios.typeInFieldinsnaps-simulationso that it properly attaches thechainIdto the input value.