Skip to content

Fix documentation and typing in TransactionParams #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix documentation and typing in TransactionParams #3237

wants to merge 2 commits into from

Conversation

Marcofann
Copy link

@Marcofann Marcofann commented Mar 17, 2025 •
edited
Loading

Fixed incorrect terminology:

  • "Network ID as per EIP-155" → "Chain ID as per EIP-155" (EIP-155 defines chainId, not network ID).

Fixed spelling mistake:

  • "Maxmimum" → "Maximum".

@Marcofann Marcofann requested a review from a team as a code owner March 17, 2025 16:37
@Marcofann
Copy link
Author

@Mrtenz , I’ve reverted the nonce type back to string to match internal usage.
Let me know if anything else needs updating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcofann @Mrtenz