Add new method to dialogs snap #3173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 511 511
Lines 11313 11313
Branches 1741 1741
=======================================
Hits 10746 10746
Misses 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
requested changes
Mar 3, 2025
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
Outdated
Show resolved
Hide resolved
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
Outdated
Show resolved
Hide resolved
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
Show resolved
Hide resolved
| @@ -90,6 +90,12 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => { | |||
| }, | |||
| }); | |||
|
|
|||
| case 'showRequireScrollContent': | |||
There was a problem hiding this comment.
Suggested change
| case 'showRequireScrollContent': | |
| case 'showLongContent': |
There was a problem hiding this comment.
Can we use this naming instead ?
There was a problem hiding this comment.
Yup, updated: 98d4964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to show require scroll content to allow for e2e testing of the new
requireScrollfooter prop.