Cache snap state in memory #2980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/cache-state
branch
from
19202f3 to
1a95f6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
==========================================
+ Coverage 94.74% 94.75% +0.01%
==========================================
Files 497 497
Lines 10868 10896 +28
Branches 1669 1674 +5
==========================================
+ Hits 10297 10325 +28
Misses 571 571 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/cache-state
branch
from
2c7f8fa to
cd4b9b3
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
| encrypted: boolean, | ||
| ) { | ||
| const runtime = this.#getRuntimeExpect(snapId); | ||
| await runtime.stateMutex.runExclusive(async () => { |
There was a problem hiding this comment.
Technically we would probably only need a mutex for encrypted storage since regular storage is synchronous? Do you think it is preferable to have both operations under the same mutex?
There was a problem hiding this comment.
The call to #persistSnapState is asynchronous, so to avoid possible race conditions, I think this makes sense?
FrederikBolding
approved these changes
Jan 13, 2025
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
To improve performance when using state, especially when using the new state methods (#2916), we now cache state in memory, and write updates to disk asynchronously. The first time the state is fetched, it's cached in the Snap's runtime data, which is used in subsequent calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve performance when using state, especially when using the new state methods (#2916), we now cache state in memory, and write updates to disk asynchronously. The first time the state is fetched, it's cached in the Snap's runtime data, which is used in subsequent calls.