BREAKING: Add support for new state methods to snaps-simulation
#2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
==========================================
+ Coverage 94.57% 94.59% +0.01%
==========================================
Files 492 493 +1
Lines 10625 10654 +29
Branches 1635 1635
==========================================
+ Hits 10049 10078 +29
Misses 576 576 ☔ View full report in Codecov by Sentry. |
| * @returns The state of the Snap. | ||
| * @yields Selects the state from the store. | ||
| */ | ||
| function* getSnapStateImplementation(encrypted: boolean): SagaIterator<string> { |
There was a problem hiding this comment.
IIRC we already have a function for this, can we dedupe?
There was a problem hiding this comment.
This hook doesn't expect an origin as first parameter, so it's slightly different.
Mrtenz
changed the title
snaps-simulationsnaps-simulation
Mrtenz
force-pushed
the
mrtenz/state-methods-snaps-jest
branch
from
6cc7dad to
ce25973
Compare
FrederikBolding
approved these changes
Dec 19, 2024
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
) This adds support for the state methods introduced in #2916 to `snaps-simulation` (and `snaps-jest`), and updates the example to test these methods as well. ## Breaking changes - The middleware hooks in `snaps-simulation` were separated into two separate types, `PermittedMiddlewareHooks` and `RestrictedMiddlewareHooks`. - The `MiddlewareHooks` type was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the state methods introduced in #2916 to
snaps-simulation(andsnaps-jest), and updates the example to test these methods as well.Breaking changes
snaps-simulationwere separated into two separate types,PermittedMiddlewareHooksandRestrictedMiddlewareHooks.MiddlewareHookstype was removed.