Add support for button form property in snaps-simulation
#2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 484 484
Lines 10337 10341 +4
Branches 1575 1576 +1
=======================================
+ Hits 9764 9768 +4
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/simulation-button-form
branch
from
f47a98a
to
b22869f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2712 we added a
formproperty to the button component, but we didn't add support tosnaps-simulation/snaps-jest. In this PR I've added some logic tosnaps-simulationto support this prop, so that forms are submitted when a button is placed outside a form with this prop.