Add AccountSelector to Box and Field children
#2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
FrederikBolding
previously approved these changes
Sep 30, 2024
|
@GuillaumeRx Needs some updates to tests it seems |
Yes, I'm also adding more things to this PR. Hold on :) |
GuillaumeRx
changed the title
AccountSelector to Box childrenAccountSelector to Box and Field children
| @@ -341,7 +341,6 @@ export const AccountSelectorStruct: Describe<AccountSelectorElement> = element( | |||
| 'AccountSelector', | |||
| { | |||
| name: string(), | |||
| title: string(), | |||
There was a problem hiding this comment.
Does the account selector have a static title now?
There was a problem hiding this comment.
I dropped this in favour of the usage of the Field's label prop :)
FrederikBolding
previously approved these changes
Sep 30, 2024
FrederikBolding
approved these changes
Sep 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 482 482
Lines 10261 10261
Branches 1563 1563
=======================================
Hits 9688 9688
Misses 573 573 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
added a commit
that referenced
this pull request
Oct 4, 2024
This reverts commit 6cc4791.
GuillaumeRx
added a commit
that referenced
this pull request
Oct 4, 2024
This reverts commit 6cc4791.
GuillaumeRx
added a commit
that referenced
this pull request
Oct 7, 2024
This reverts commit 6cc4791.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the forgotten addition of the
AccountSelectortoBoxchildrens list.It also allows the usage of
AccountSelectorin theFieldcomponent.The
titleprop of theAccountSelectorwas also dropped in favor of wrapping this component inside of aField.