feat: Add the size prop to Heading
#2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
commented
Sep 25, 2024
Comment on lines
+42
to
+43
| * @param props.alignment - The alignment of the text. | ||
| * @param props.color - The color of the text. |
There was a problem hiding this comment.
Also added some missing JSDOC params to Text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
Coverage 94.38% 94.38%
=======================================
Files 477 477
Lines 10204 10204
Branches 1557 1557
=======================================
Hits 9631 9631
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
sizeprop to theHeadingcomponent. I can bemdorlg.