Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derivation path for Nimiq #2309

Merged

Conversation

Eligioo
Copy link
Contributor

@Eligioo Eligioo commented Mar 28, 2024

Specify the derivation path for Nimiq so its name is resolved when deriving public and private keys.

@Eligioo Eligioo requested a review from a team as a code owner March 28, 2024 19:30
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (51a1d04) to head (3cdca52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2309   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         337      337           
  Lines        7689     7689           
  Branches     1193     1193           
=======================================
  Hits         7430     7430           
  Misses        259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit b461d93 into MetaMask:main Apr 1, 2024
150 checks passed
@FrederikBolding
Copy link
Member

Thanks!

@Eligioo Eligioo deleted the feature/nimiq-derivation-path branch April 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants