Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Jest expect types #2308

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Improve Jest expect types #2308

merged 1 commit into from
Mar 27, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 27, 2024

This improves the expect function types by:

  • Adding documentation to each matcher.
  • Removing duplication between the regular and asymmetric matchers.
  • Removing the need to import expect from @jest/globals (though this is still recommended by Jest).

@Mrtenz Mrtenz requested a review from a team as a code owner March 27, 2024 11:32
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (0eda215) to head (69fc744).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         337      337           
  Lines        7615     7615           
  Branches     1180     1180           
=======================================
  Hits         7356     7356           
  Misses        259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit de7fc0e into main Mar 27, 2024
150 checks passed
@Mrtenz Mrtenz deleted the mrtenz/jest-types branch March 27, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants