Enforce JSON-RPC response size limits #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 332 332
Lines 7556 7564 +8
Branches 1170 1171 +1
=======================================
+ Hits 7298 7306 +8
Misses 258 258 ☔ View full report in Codecov by Sentry. |
hmalik88
reviewed
Feb 20, 2024
| * @param response - The response. | ||
| * @returns True if the response is valid, otherwise false. | ||
| */ | ||
| export function isValidResponse(response: Record<string, unknown>) { |
There was a problem hiding this comment.
You have a test for this function, but codecov is saying these lines are uncovered? 🤔
There was a problem hiding this comment.
Yeah, utils.ts has better coverage in the browser tests and therefore that is chosen when merging the two coverage reports. Not much we can do about this right now 🤷♂️
Mrtenz
reviewed
Feb 21, 2024
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
FrederikBolding
force-pushed
the
fb/json-rpc-response-limits
branch
from
02f241e
to
e835981
Compare
Mrtenz
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces a size limit on JSON-RPC responses from Snaps, throwing an error if the object is larger than 64 MB.
64 MB was chosen because it seems to be the limit set by Chrome for postMessage between the extension and dapps: https://source.chromium.org/chromium/chromium/src/+/main:extensions/renderer/api/messaging/messaging_util.cc;l=65?q=%22Message%20length%20exceeded%20maximum%20allowed%20length%22&ss=chromium