-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devDeps: bump vite and webdriverio #2121
base: main
Are you sure you want to change the base?
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhy is contributor and author data important?Package does not specify a list of contributors or an author in package.json. Add a author field or contributors array to package.json. What is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 312 312
Lines 7042 7042
Branches 1104 1104
=======================================
Hits 6807 6807
Misses 235 235 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but there's a lot of lint errors currently:
https://github.com/MetaMask/snaps/actions/runs/7613049917/job/20732121835?pr=2121
- Closes: - CVE-2024-23331 / GHSA-c24v-8rfc-w8vw - CVE-2023-49293 / GHSA-92r3-m2mg-pj97 - Bump vite-tsconfig-paths@^4.0.5->^4.3.1
- remove dependency on vite ~4.4.6
Looks like the linter thinks we should await expectations in WDIO now 🤔 Did the API change without a major version bump? 🤔 |
This comment was marked as resolved.
This comment was marked as resolved.
@FrederikBolding : I see the errors crop up down to wdio 8.20. It turns out that on current snaps main and for older wdio versions, Haven't actually tracked down where that change is introduced, yet. (see action results for each commit for reference: legobeat#10)
|
This seems related: webdriverio/webdriverio#11999 |
vite
from 4.4 to 4.5.@wdio/*
from^8.19.0
to^8.28.0
vite@~4.4.6
- deduping it