Validate local snap URL protocols #1005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
=======================================
Coverage 92.67% 92.68%
=======================================
Files 93 93
Lines 9224 9236 +12
Branches 894 894
=======================================
+ Hits 8548 8560 +12
Misses 676 676
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
reviewed
Nov 23, 2022
Comment on lines
+2298
to
+2306
| const callActionMock = jest | ||
| .spyOn(messenger, 'call') | ||
| .mockImplementation((method, ..._args: unknown[]) => { | ||
| if (method === 'PermissionController:hasPermission') { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| }); |
Member
There was a problem hiding this comment.
This shouldn't be necessary anymore, since #983 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we only accept
http:orhttps:as the URL protocols for locally hosted snaps. Previously you could provide any protocol accepted by theURLconstructor, for examplefoo:. New test cases are added for snap installs and updates.