Skip to content

feat: add from/to to confirmation #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

feat: add from/to to confirmation #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/snap/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"version": "1.4.5",
"version": "1.5.0",
"description": "Manage Bitcoin using MetaMask",
"proposedName": "Bitcoin",
"repository": {
"type": "git",
"url": "https://github.com/MetaMask/snap-bitcoin-wallet.git"
},
"source": {
"shasum": "nGyqPBVxGl7PFfJfi2eo+6zuj0ExrR55GPcK8mKy/lU=",
"shasum": "j9W3ulkpAGrL0lkkChX7wavGEY3qq6nCf4lQ0KmmF78=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
28 changes: 26 additions & 2 deletions packages/snap/src/infra/jsx/unified-send-flow/UnifiedSendFormView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export const UnifiedSendFormView: SnapComponent<UnifiedSendFormViewProps> = ({
messages,
}) => {
const t = translate(messages);
const { amount, exchangeRate, network, from, explorerUrl } = context;
const { amount, exchangeRate, network, from, recipient, explorerUrl } =
context;

const psbt = Psbt.from_string(context.psbt);
const fee = psbt.fee().to_sat();
Expand Down Expand Up @@ -87,7 +88,7 @@ export const UnifiedSendFormView: SnapComponent<UnifiedSendFormViewProps> = ({
<Box>{null}</Box>
<Box alignment="space-between" direction="horizontal">
<SnapText fontWeight="medium" color="alternative">
{t('confirmation.account')}
{t('from')}
</SnapText>
{isValidSnapLinkProtocol(explorerUrl) ? (
<Link href={displayExplorerUrl(explorerUrl, from)}>
Expand All @@ -98,6 +99,29 @@ export const UnifiedSendFormView: SnapComponent<UnifiedSendFormViewProps> = ({
)}
</Box>
<Box>{null}</Box>
<Box alignment="space-between" direction="horizontal">
<SnapText fontWeight="medium" color="alternative">
{t('toAddress')}
</SnapText>
{isValidSnapLinkProtocol(explorerUrl) ? (
<Link href={displayExplorerUrl(explorerUrl, recipient)}>
<Address
address={displayCaip10(network, recipient)}
truncate
displayName
avatar
/>
</Link>
) : (
<Address
address={displayCaip10(network, recipient)}
truncate
displayName
avatar
/>
)}
</Box>
<Box>{null}</Box>
<Box alignment="space-between" direction="horizontal">
<SnapText fontWeight="medium" color="alternative">
{t('network')}
Expand Down