-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add support for setSelectedAccounts
#543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
aganglada
reviewed
Oct 14, 2025
orestiseth
commented
Oct 14, 2025
setSelectedAccountssetSelectedAccounts
…s-syncing # Conflicts: # packages/snap/snap.manifest.json
aganglada
approved these changes
Oct 21, 2025
Contributor
aganglada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me
xavier-brochard
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Implements
setSelectedAccounts, updates cron to synchronize only selected accounts, adjusts account creation defaults, and updates tests and dependencies.src/handlers/KeyringHandler.ts):KeyringRpcMethod.SetSelectedAccountscallingsetSelectedAccounts.setSelectedAccounts(accounts)validates IDs and triggersfullScanon selected accounts.createAccountdefaultsynchronizetofalse.discoverAccountsno longer filters by transaction history (returns all discovered accounts).src/handlers/CronHandler.ts):SnapsProviderand usegetSelectedAccountsto sync only selected accounts.src/index.ts.src/handlers/validation.ts):validateSelectedAccountsto ensure provided IDs exist; throwsValidationError.src/use-cases/AccountUseCases.ts):discoverno longer performsfullScan.snap_manageAccountsgetSelectedAccounts, reflect new defaults, and new behaviors (CronHandler.test.ts, integration tests,KeyringHandler.test.ts,AccountUseCases.test.ts).@metamask/keyring-apito^21.1.0,@metamask/keyring-snap-sdkto^7.1.0,@metamask/snaps-jestto^9.4.1(and related lockfile updates).snap.manifest.jsonsourceshasum.Written by Cursor Bugbot for commit e553517. This will update automatically on new commits. Configure here.