Skip to content

Prevent JS prompts during loading #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

jpcloureiro
Copy link

Block JS prompts during page loading.

Patch ported from this commit: MetaMask/metamask-mobile@5ee210a

Addresses https://github.com/MetaMask/mobile-planning/issues/1757

Platform: iOS & Android

@jpcloureiro jpcloureiro requested review from sethkfman and Cal-L May 8, 2024 14:01
@jpcloureiro jpcloureiro self-assigned this May 8, 2024
@jpcloureiro
Copy link
Author

iOS workflows requires #21 to pass

Copy link

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpcloureiro jpcloureiro merged commit a1144d9 into main May 8, 2024
@jpcloureiro jpcloureiro deleted the prevent-jsprompts-onload branch May 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants