Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Aug 24, 2023

@legobeat
Copy link
Contributor Author

legobeat commented Aug 24, 2023

This happens regardless of if bumping @metamask/utils or not:

https://github.com/MetaMask/providers/actions/runs/5958076982/job/16161797970
https://github.com/MetaMask/providers/actions/runs/5959652471/job/16165741468?pr=275

Error: src/utils.ts(51,7): error TS2322: Type 'JsonRpcError<JsonRpcRequest<Json[] | Record<string, Json> | undefined>>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.
  Types of property 'data' are incompatible.
    Type 'JsonRpcRequest<Json[] | Record<string, Json> | undefined>' is not assignable to type 'Json | undefined'.
      Type 'JsonRpcRequest<Json[] | Record<string, Json> | undefined>' is not assignable to type '{ [prop: string]: Json; }'.
        Property 'params' is incompatible with index signature.
          Type 'Json[] | Record<string, Json> | undefined' is not assignable to type 'Json'.
            Type 'undefined' is not assignable to type 'Json'.
Error: Process completed with exit code 2.

Attempt at fix: MetaMask/utils#130
Validation of fix: #276

@legobeat legobeat force-pushed the bump-json-rpc-engine branch from 2b0cb1b to 2534c28 Compare August 24, 2023 04:53
@legobeat
Copy link
Contributor Author

legobeat commented Sep 1, 2023

#277

@legobeat legobeat closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants