generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 6
build(kernel-test): Bundle test vats from typescript source #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grypez
wants to merge
8
commits into
main
Choose a base branch
from
grypez/typescript-vats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
83a13ec to
38d9d6f
Compare
38d9d6f to
6f883aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(kernel-test): Convert vat source files to TypeScript
Summary
TestPowerstype andunwrapTestLoggerutility for test vats that need structured loggingChanges
ocap-kernel:
buildRootObjectparameter typeskernel-test:
.jsto.tstest-powers.tswithTestPowerstype andunwrapTestLoggerutilityTestPowersfor typed logger accesscli:
.tsfiles (still matches.js, too)Note
Medium Risk
Mostly test and tooling changes, but it touches the CLI bundling glob and exports new public types from
@metamask/ocap-kernel, which could affect downstream builds if assumptions about source extensions or type exports differ.Overview
Test vats are now authored in TypeScript and bundled from
.tssources. The CLIbundleDircommand expands its glob to include*.{js,ts}so vat bundles can be generated directly from TS entrypoints.kernel-testvats were converted from.jsto.tswith stronger typing and standardized logging. A newTestPowerstype plusunwrapTestLoggerhelper centralize structured test logging, and vats add explicit parameter/service/baggage types (including durableBaggageuse).ocap-kernelexposes additional public types.VatPowersandBaggageare now exported from@metamask/ocap-kernelto support typed vat power signatures in tests.Written by Cursor Bugbot for commit 30f557f. This will update automatically on new commits. Configure here.