Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 30, 2021

These options were taken from the metamask-module-template repo. The changes are as follows:

  • inlineSources: true - Embeds inline source maps in the output, which is critically important for making sense of stack traces that lead into this package.
  • lib: ["ES2020"] - Include ES2020 built-in type definitions.
  • rootDir - Explicitly set the root directory. This is important for catching misconfiguration that might alter the implicit root directory.

These options were taken from the `metamask-module-template` repo. The
changes are as follows:

* `inlineSources: true` - Embeds inline source maps in the output,
which is critically important for making sense of stack traces that
lead into this package.
* `lib: ["ES2020"]` - Include ES2020 built-in type definitions.
* `rootDir` - Explicitly set the root directory. This is important for
catching misconfiguration that might alter the implicit root directory.
@Gudahtt Gudahtt requested a review from a team as a code owner June 30, 2021 05:20
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Gudahtt Gudahtt merged commit 2b1ad49 into main Jun 30, 2021
@Gudahtt Gudahtt deleted the use-standard-typescript-options branch June 30, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants