Remove readable-stream
#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package was only being used in tests. The tests are always run in `Node.js`, so I switched them to use the built-in Node.js stream API instead. I'm guessing this package was originally included to allow using this package in either the browser or Node.js. But it wasn't setup that way. I did consider using `readable-stream` in place of `stream` to make browser compatibility easier for consumers, but that would have required more effort to get working, as the version of `readable-stream` in-use was outdated and incompatible with this package. Plus it's fairly common for bundlers to replace built-in modules like `stream` on-the-fly so it would have been of marginal benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was only being used in tests. The tests are always run in
Node.js, so I switched them to use the built-in Node.js stream API instead.I'm guessing this package was originally included to allow using this package in either the browser or Node.js. But it wasn't setup that way. I did consider using
readable-streamin place ofstreamto make browser compatibility easier for consumers, but that would have required more effort to get working, as the version ofreadable-streamin-use was outdated and incompatible with this package. Plus it's fairly common for bundlers to replace built-in modules likestreamon-the-fly so it would have been of marginal benefit.