Skip to content

Conversation

@Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Sep 23, 2025

Depends in #7

  • Adds native keccak256
  • Adds native hmacSha512
  • Adds native pubToAddress
Screenshot_1758890445

@Nodonisko Nodonisko requested a review from a team as a code owner September 23, 2025 14:08
@Nodonisko Nodonisko changed the title Feat: keccak256 Feat: keccak256, pubToAddress, hmacSha512 Sep 26, 2025
sethkfman and others added 2 commits October 8, 2025 09:24
- Botan is popular crypto library with great performance and modularity
- We are going to to use it for `keccak256` and `hmacSha512`
implementation and possibly others in future
- Security audit by German government agency
https://www.bsi.bund.de/EN/Themen/Unternehmen-und-Organisationen/Informationen-und-Empfehlungen/Kryptografie/Kryptobibliothek-Botan/kryptobibliothek-botan_node.html
- It requires little bit special build process for different
architectures and operating system but thanks to that it could offer
superior performance for some operations like SHA512 that has support in
arm64 directly

---------

Co-authored-by: Daniel Suchý <suchydan@gmail.com>
@socket-security
Copy link

socket-security bot commented Oct 8, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman enabled auto-merge (squash) October 29, 2025 22:12
@sethkfman sethkfman merged commit ba9b479 into MetaMask:main Oct 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants