Don't explicitly throw in readme-lists-correct-yarn-version

MetaMask · Jan 4, 2024 · ae3da2c · ae3da2c
1 parent 404f75f
commit ae3da2c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/src/rules/readme-lists-correct-yarn-version.test.ts b/src/rules/readme-lists-correct-yarn-version.test.ts
@@ -80,7 +80,7 @@ describe('Rule: readme-lists-correct-yarn-version', () => {
     });
   });
 
-  it('throws if the template does not have the Yarn version listed in its README for some reason', async () => {
+  it('passes if the template does not have the Yarn version listed in its README for some reason', async () => {
     expect.assertions(1);
 
     await withinSandbox(async (sandbox) => {
@@ -101,14 +101,16 @@ describe('Rule: readme-lists-correct-yarn-version', () => {
         'does not matter',
       );
 
-      await expect(
-        readmeListsCorrectYarnVersion.execute({
-          template,
-          project,
-          pass,
-          fail,
-        }),
-      ).rejects.toThrow("Could not find Yarn version in template's README");
+      const result = await readmeListsCorrectYarnVersion.execute({
+        template,
+        project,
+        pass,
+        fail,
+      });
+
+      expect(result).toStrictEqual({
+        passed: true,
+      });
     });
   });
 });
diff --git a/src/rules/readme-lists-correct-yarn-version.ts b/src/rules/readme-lists-correct-yarn-version.ts
@@ -14,10 +14,12 @@ export default buildRule({
 
     const match = fileContentInTemplate.match(/Install \[Yarn .+?\]\(.+?\)/u);
     if (!match?.[0]) {
-      throw new Error(
+      console.warn(
         "Could not find Yarn version in template's README. This is not the fault of the project, but is rather a bug in a rule.",
       );
+      return pass();
     }
+
     if (!fileContentInProject.includes(match[0])) {
       return fail([
         {