Skip to content

Conversation

@tommasini
Copy link
Contributor

@tommasini tommasini commented Jun 10, 2024

Description

Update signature controller to v^16.

Related issues

Fixes:

Manual testing steps

  1. Go to test dapp
  2. connect wallet
  3. test personal sign and multiple sign type versions

Screenshots/Recordings

Screen.Recording.2024-06-10.at.11.36.21.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team Run Smoke E2E labels Jun 10, 2024
@tommasini tommasini requested a review from a team as a code owner June 10, 2024 10:42
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/signature-controller@16.0.0 Transitive: filesystem +9 2.68 MB metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@14.0.1

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fcb2a58
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4daee065-a24b-4d5f-a6b1-1a72c497bf9e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tommasini tommasini merged commit 505c673 into main Jun 11, 2024
@tommasini tommasini deleted the chore/signature-controller-v16 branch June 11, 2024 11:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 11, 2024
@metamaskbot metamaskbot added the release-7.26.0 Issue or pull request that will be included in release 7.26.0 label Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.26.0 Issue or pull request that will be included in release 7.26.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants